Fix two issues related to event propagation #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the event bubbles up to the map and changes the start or end point of the route to the position of the close button.
Firefox does not support the deprecated [1] 'mousewheel' event, so scrolling when over the itinerary element resulted in zooming of the map instead of scrolling the itinerary as the event is propagated. According to [2], the 'mousewheel' event must currently still be supported because of Safari. [1] https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event [2] https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently are two issues caused by event propagation:
This should get fixed by this PR.